Skip to content

Update InteropServices doc #7107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 6, 2021
Merged

Update InteropServices doc #7107

merged 4 commits into from
Sep 6, 2021

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Sep 3, 2021 •
edited
Loading

@gewarren

This comment has been minimized.

Sign in to view
carlossanlop
carlossanlop approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of this, @AaronRobinsonMSFT .

@gewarren
Copy link
Contributor

gewarren commented Sep 4, 2021

Docs Build status updates of commit a116e28:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.InteropServices/Architecture.xml ✅Succeeded View
xml/System.Runtime.InteropServices/CollectionsMarshal.xml ✅Succeeded View
xml/System.Runtime.InteropServices/MemoryMarshal.xml ✅Succeeded View
xml/System.Runtime.InteropServices/PosixSignalContext.xml ✅Succeeded View
xml/System.Runtime.InteropServices/UnmanagedCallConvAttribute.xml ✅Succeeded View
xml/ns-System.Runtime.InteropServices.ObjectiveC.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

carlossanlop
carlossanlop reviewed Sep 4, 2021
View reviewed changes
xml/System.Runtime.InteropServices.ObjectiveC/ObjectiveCMarshal.xml
<Parameter Name="unhandledExceptionPropagationHandler" Type="System.Runtime.InteropServices.ObjectiveC.ObjectiveCMarshal+UnhandledExceptionPropagationHandler" />
</Parameters>
<Docs>
<param name="beginEndCallback">To be added.</param>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewarren @joelmartinez the DocId of this API is really unconventional. This prevented the DocsPortingTool from matching documentation from the IntelliSense xml files and port it.

The IntelliSense xml file looks even worse: M:System.Runtime.InteropServices.ObjectiveC.ObjectiveCMarshal.Initialize(,,,System.Runtime.InteropServices.ObjectiveC.ObjectiveCMarshal.UnhandledExceptionPropagationHandler)

Just wanted you to know in case you see issues with these ObjectiveC related APIs.

@gewarren
Copy link
Contributor

gewarren commented Sep 4, 2021

Docs Build status updates of commit 21f43d3:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.InteropServices.ObjectiveC/ObjectiveCMarshal+UnhandledExceptionPropagationHandler.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ObjectiveC/ObjectiveCMarshal.xml ✅Succeeded View
xml/System.Runtime.InteropServices/Architecture.xml ✅Succeeded View
xml/System.Runtime.InteropServices/CollectionsMarshal.xml ✅Succeeded View
xml/System.Runtime.InteropServices/MemoryMarshal.xml ✅Succeeded View
xml/System.Runtime.InteropServices/PosixSignalContext.xml ✅Succeeded View
xml/System.Runtime.InteropServices/UnmanagedCallConvAttribute.xml ✅Succeeded View
xml/ns-System.Runtime.InteropServices.ObjectiveC.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop carlossanlop merged commit c5cf285 into dotnet:net6-rc1 Sep 6, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the update_interop2 branch September 6, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky

@gewarren gewarren Awaiting requested review from gewarren

1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Runtime.InteropServices

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AaronRobinsonMSFT @gewarren @carlossanlop